fix(IAM Policy Management): Add operator support to subject_attributes in Authorziation Policy #5076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s in Authorziation Policy Signed-off-by: Shaun Colley <shaun.colley@ibm.com>
Signed-off-by: Shaun Colley <shaun.colley@ibm.com>
Signed-off-by: Shaun Colley <shaun.colley@ibm.com>
|
Tests after latest commit: $ make testacc TESTARGS='-run=TestAccIBMIAMAccessGroupPolicy'
...
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/iampolicy 489.073s
...
$ make testacc TESTARGS='-run=TestAccIBMIAMAuthorizationPolicy'
...
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/iampolicy 140.749s
...
$ make testacc TESTARGS='-run=TestAccIBMIAMUserPolicy'
...
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/iampolicy 352.565s |
|
@swcolley fix the conflicts in files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updated authorization policy to support operator in subject_attributes as well as wildcard support. Updated other minor failing tests.
Note: leaving as draft until go sdk PR IBM/platform-services-go-sdk#297 is merged. Then I can update this PR with go.mod and go.sum changes.
Community Note
Closes IAM issue #2140
Output from acceptance testing:
Ran user policy test for sanity check to make sure there was no impact from any other changes.